-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmark for interaction (zoom) #73
Merged
droumis
merged 5 commits into
holoviz-topics:main
from
ianthomas23:multiple_benchmarks_per_scenario
Sep 25, 2023
Merged
Add benchmark for interaction (zoom) #73
droumis
merged 5 commits into
holoviz-topics:main
from
ianthomas23:multiple_benchmarks_per_scenario
Sep 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noice
|
droumis
reviewed
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ianthomas23 , this looks/works great. I left a couple (for the future) comments but I am happy to merge now. One thing I wanted to get your opinion on was changing the zoom interaction as described in my comment..
zoom out to mimic common user interaction
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a benchmark for zooming an existing Bokeh figure, so records the time taken for re-rendering the figure (and any recalculation prior to that required for the re-render). It is achieved by creating a button whose callback zooms the figure so the Playwright functionality is to locate the button and click it in the same way as already performed for the latency benchmark. All of the important work occurs in JavaScript in the browser (and possibly GPU), except for some constant-ish overhead of sending the zoom request from the Python side and waiting for the render completion message to arrive on the Python side.
This is part of issue #66.
Summary of changes:
Base
benchmark sets thenumber
andwarmup_time
of benchmark runs. This is really important here as the defaultasv
behaviour assumes that the results of thesetup
stage are not affected by the actual benchmark runs whereas here that is not the case.Timeseries
toBokehExample
.Base
class so that the actual benchmark classes are as simple as possible.n = 10_000_000
runs as this sometimes gives problems with timeouts that I have yet to solve.On my M1 mac (no dedicated GPU) I obtain the following: