Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect docs to current version #352

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Redirect docs to current version #352

merged 2 commits into from
Nov 20, 2024

Conversation

glarizza
Copy link
Contributor

PROBLEM:

See #350 for context. There's a GitHub issue open for this on the
facebook docusaurus repo:
facebook/docusaurus#9049

SOLUTION:

Use the redirect workaround for the time being.

OUTCOME:

https://holos.run/docs will link to the most recent version of our docs
site.

Copy link

cloudflare-workers-and-pages bot commented Nov 20, 2024

Deploying holos with  Cloudflare Pages  Cloudflare Pages

Latest commit: 43c6183
Status:⚡️  Build in progress...

View logs

PROBLEM:

See #350 for context. There's a GitHub issue open for this on the
facebook docusaurus repo:
facebook/docusaurus#9049

SOLUTION:

Use the redirect workaround for the time being.

OUTCOME:

https://holos.run/docs will link to the most recent version of our docs
site.
@glarizza glarizza force-pushed the gl/350-docs-redirect branch from 978c5c2 to d91b30e Compare November 20, 2024 23:18
doc/website/static/_redirects Outdated Show resolved Hide resolved
@natemccurdy
Copy link
Contributor

Just so I understand this correctly, the _redirect file is service-side redirect config supported by CloudFlare, and we will have to update the redirect any time a new API version is pushed (e.g. v1alpha6)?

@jeffmccune jeffmccune merged commit 9b10e23 into main Nov 20, 2024
3 of 4 checks passed
@jeffmccune jeffmccune deleted the gl/350-docs-redirect branch November 20, 2024 23:33
@jeffmccune
Copy link
Contributor

the _redirect file is service-side redirect config supported by CloudFlare, and we will have to update the redirect any time a new API version is pushed (e.g. v1alpha6)?

@natemccurdy Yes that's correct.

curl https://gl-350-docs-redirect.holos.pages.dev/docs
Redirecting to /docs/v1alpha5

@jeffmccune
Copy link
Contributor

FYI, @glarizza @natemccurdy Cloudflare tacks a / on the end of all the URL's, so I changed the redirects to match and handle both /docs and /docs/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants