Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test.yml - add node 20.x #272

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

mcm1957
Copy link
Contributor

@mcm1957 mcm1957 commented Dec 18, 2023

Please consider adding node 20.x to you test matrix ad node 20.x is already released and used by part of ioBroker community.

If node 20.x causes any problems with your adapter, feel free to omit it from tests for now but create a issue describing the problem and try to fix it as soon as your time allows.

Thanks a lot for supporting ioBroker.
mcm1957

@mcm1957 mcm1957 requested a review from holomekc as a code owner December 18, 2023 08:29
@holomekc
Copy link
Owner

Hi @mcm1957 ,

sure no problem. One thing. I am always checking here:
https://github.com/ioBroker/ioBroker.example/blob/master/TypeScript/.github/workflows/test-and-release.yml

Maybe the templates should include 20.x as well.

@holomekc holomekc merged commit 5c3c68d into holomekc:master Dec 18, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants