Hotfix/fix job decoding #570
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gic show internal errors
src/utils/network-monitor.ts
Outdated
| @@ -2077,15 +2078,22 @@ export class NetworkMonitor { | |||
| return result | |||
| } | |||
| } catch (error: any) { | |||
| this.structuredLogError(network, error.message) | |||
| internalError = error | |||
| // this.structuredLog(network, `function ${func.name} failed ${i} of ${attempts}`) | |||
There was a problem hiding this comment.
should this just be removed or are you just disabling it for now?
src/events/events.ts
Outdated
| // NOTE: This function can be optimized as its currently inefficient | ||
|
|
||
| // This is a fallback for the legacy LayerZeroModule contract address that was updated for all networks | ||
| const toFind3 = '0x6f484Eacd997D9880205aF22f6a4881ea0e1CCd7'.toLowerCase().slice(2, 42) |
There was a problem hiding this comment.
maybe instead of just numbering these toFind functions it would be nicer to name thing something more descriptive like toFindFallbackLZ or something like that
alexanderattar
approved these changes
Aug 21, 2023
|
Looks like prettier issues and a conflict, but otherwise makes sense |
…d issue with retry not sleeping if request was successful but returned null.
| if (result !== null) { | ||
| return result | ||
| } | ||
| } catch (error: any) { | ||
| this.structuredLogError(network, `Attempt ${i + 1} failed: ${error.message}`) |
There was a problem hiding this comment.
You don't want a log to keep track of how many attempts have been made anymore? I found this to be helpful before
| polygon: BigNumber.from('2500000000000000'), | ||
| etherum: BigNumber.from('5400000000000000'), |
alexanderattar
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Changes
I made this better by doing ...
Checklist before requesting a review