-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/operator stability improvement #568
Conversation
…g, error handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may also want to log some variables in the processOperatorJob
and processOperatorJobs
function as this is the set of functions that actually submit the tx.
… (reading 'name')
…nic if we don't have the network
…revent continous loop
// eslint-disable-next-line no-constant-condition | ||
while (true) { | ||
try { | ||
await this.processOperatorJobs(network) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I like this change to make processing more linear. One trade off is that this may also cause delays if this function takes time to execute. Just calling out the trade off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Describe Changes
processSingleTransaction
into smaller handler functionsChecklist before requesting a review