Initial pass at adding logic to capture the type of xchain message #561

alexanderattar · 2023-07-20T22:59:36Z

Describe Changes

Enables differentiating between NFT and CONTRACT cross chain messages
Adds a new function detectCrossChainMessageType that is called within the EventType.CrossChainMessageSent block and the EventType.AvailableOperatorJob blocks of the processSingTransaction function to send the correct type (at the moment either CONTRACT or ERC721) through sqs to the processor
Updates BridgeEventPayload to allow passing a crossChainMessageType
Adds a separate sqs event type for ContractDeployedEventPayload
Includes that as one of the options of payload format in SqsMessageBody

Checklist before requesting a review

I have performed a self-review of my code
Code styles have been enforced
I have checked eslint

src/commands/indexer/index.ts

sogoiii · 2023-07-21T18:11:21Z

src/commands/indexer/index.ts

@@ -559,13 +586,21 @@ export default class Indexer extends HealthCheck {
            const availableOperatorJobEvent: AvailableOperatorJobEvent | null = this.bloomFilters[
              type
            ]!.bloomEvent.decode<AvailableOperatorJobEvent>(type, interestingTransaction.log!)
+
+            if (!interestingTransaction.allLogs) {
+              throw new Error('CrossChainMessageSentEvent has no allLogs')


Will this actually stop the processes? Or is it caught and continue?

Initial pass at adding logic to capture the type of xchain message

ccff4c0

sogoiii reviewed Jul 21, 2023

View reviewed changes

src/commands/indexer/index.ts Outdated Show resolved Hide resolved

Cleanup loop to detect xchain message type into a function

73d35f3

alexanderattar marked this pull request as ready for review July 21, 2023 01:55

alexanderattar added 2 commits July 20, 2023 21:57

Cleanup

d8a2fb6

Use functional style and reuse bloom filter event types

92aeeaf

sogoiii reviewed Jul 21, 2023

View reviewed changes

BravoNatalie approved these changes Jul 21, 2023

View reviewed changes

alexanderattar merged commit 1a28453 into develop Jul 21, 2023

alexanderattar deleted the feature/HOLO-1054-detect-crosschain-message-type branch July 21, 2023 19:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial pass at adding logic to capture the type of xchain message #561

Initial pass at adding logic to capture the type of xchain message #561

alexanderattar commented Jul 20, 2023 •

edited

Loading

sogoiii Jul 21, 2023

Initial pass at adding logic to capture the type of xchain message #561

Initial pass at adding logic to capture the type of xchain message #561

Conversation

alexanderattar commented Jul 20, 2023 • edited Loading

Describe Changes

Checklist before requesting a review

sogoiii Jul 21, 2023

Choose a reason for hiding this comment

alexanderattar commented Jul 20, 2023 •

edited

Loading