fix: lit template ts error #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c12i
added
the
ShouldBackport/0.4
|
Build is failing because of tryorama issue with running hc s create, fix in in place at holochain/holochain#4630 |
c12i
added
should_backport
jost-s
approved these changes
Feb 3, 2025
ThetaSinner
approved these changes
Feb 4, 2025
|
Does this one need backporting? |
|
Already "backported" via a separate PR (#450), |
c12i
added a commit
that referenced
this pull request
Feb 11, 2025
c12i
added a commit
that referenced
this pull request
Mar 3, 2025
* Bump versions * nix flake update * Bump holochain_types * Pin holo-server-bin version to most recent working version * Unpin holo-dev-server-bin * Update ci workflow * Bump to 0.5.0-dev.17 * Nix flake update * ci: Add `ci_pass` job (#454) * ci: Add `ci_pass` job * ci: Rename develop to main * Fix lit template ts error (#448) * fix: wrongly used v-if directive (#457) * Fix incorrect usage of v-if directive * Fix vue-ts type error on current record prop * Check both editing and record * Bump to dev.18 * Nix flake update * Remove test retries * Bump versions * Nix flake update * Fix signal usage * Bump tryorama * Bump dep versions * Nix flake update * Update enum usage in tests * Fix slow tests * Update app bundle sources --------- Co-authored-by: ThetaSinner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a ts error that was preventing
vite buildfrom running for lit templateshttps://github.com/holochain/scaffolding/actions/runs/12763486851/job/35573852491#step:6:1006
hc s createremoval holochain#4630