Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Bump client-js and update usage #419

Merged
merged 3 commits into from
Nov 25, 2024
Merged

fix: Bump client-js and update usage #419

merged 3 commits into from
Nov 25, 2024

Conversation

c12i
Copy link
Collaborator

@c12i c12i commented Nov 21, 2024 •
edited
Loading

This PR bumps holochain-client-js and updates it's usage in the templates.

Other additional changes include:

  • Fixes to type errors logged in the console for vue template
  • Pin typescript dependency to v5.6.3 for vue-tsc compatibility

@c12i c12i requested review from jost-s and matthme November 21, 2024 15:14
jost-s
jost-s reviewed Nov 21, 2024
View reviewed changes
Copy link

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, no, this is a mistake. cap_secret should not have been removed. I need to fix this in the JS client.

@c12i
Copy link
Collaborator Author

c12i commented Nov 22, 2024 •
edited
Loading

Ahh I see, assumed this was intentional, will keep this as draft for now PR then

@c12i c12i marked this pull request as draft November 22, 2024 10:50
@c12i c12i force-pushed the fix/client-js-0.19.0-dev.3-breaking-changes branch from 9d54ae7 to f7a5559 Compare November 25, 2024 14:16
@c12i c12i changed the title fix: Remove cap_secret param from callZome api call fix: Update client-js and usage Nov 25, 2024
@c12i c12i changed the title fix: Update client-js and usage fix: Bump client-js and update usage Nov 25, 2024
@c12i c12i marked this pull request as ready for review November 25, 2024 15:18
@c12i c12i requested a review from jost-s November 25, 2024 15:18
jost-s
jost-s approved these changes Nov 25, 2024
View reviewed changes
Copy link

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c12i c12i merged commit 50095b9 into develop Nov 25, 2024
11 checks passed
@c12i c12i deleted the fix/client-js-0.19.0-dev.3-breaking-changes branch November 25, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jost-s jost-s jost-s approved these changes

@matthme matthme Awaiting requested review from matthme

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c12i @jost-s