Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: backport and release 0.3000.9 #417

Merged
merged 8 commits into from
Nov 26, 2024

Conversation

c12i
Copy link
Collaborator

@c12i c12i commented Nov 19, 2024

Backport #397, #398, #411 and #415 and bump dependency versions for 0.3

* Fix custom template flake

* Refactor custom templates
* Update dependencies

* Remove unused dependency
* Add skip_config_check global flag to scaffolding

* Prefer not writing the scaffold config for nixified custom templates

* Fix rustfmt warning
* Fix misplaced doc comments

* Slightly refactor link_type integrity codegen
@c12i c12i requested a review from a team November 20, 2024 09:39
@jost-s
Copy link

jost-s commented Nov 20, 2024

What is being backported here?

@c12i
Copy link
Collaborator Author

c12i commented Nov 21, 2024

@jost-s updated the PR description to show the PRs I am backporting

@jost-s
Copy link

jost-s commented Nov 21, 2024

I am not equipped to do a meaningful review of this backport. I'm not familiar with the scaffolding code and there are 127 files changed with roughly 3000 lines changed, so it would be like reviewing the 4 PRs in one for me, which would take an unreasonable amount of time.

Did you cherry-pick the commits that this PR consists of?

@c12i
Copy link
Collaborator Author

c12i commented Nov 26, 2024

@jost-s yes the commits are cherry-picked from develop

Copy link

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With passing tests, that seems fine then.

* Remove dependency to holochain

* Add rust-cache

* Add cachix nix config

* Add ci job concurrency options

* Update cachix configurations

* Run rust checks/tests outside nix

* add missing components

* Cache rust builds

* Bump holochain deps

* Update rustdocs

* Build cargo deps separately

* refactor flake

* Update maintenance docs

* Add extraPullNames input to cachix actions

* Add nix_build step

* Extend extra-substituters and public-keys in nixConfig

* Fix ci workflow

* Bump client-js version
@c12i c12i merged commit 07b559f into develop-0.3 Nov 26, 2024
11 checks passed
@c12i c12i deleted the chore/backport-and-release-0.3000.9 branch November 26, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants