Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/cache rust utils #41

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Feat/cache rust utils #41

merged 2 commits into from
Feb 9, 2024

Conversation

mrruby
Copy link
Contributor

@mrruby mrruby commented Feb 9, 2024

How do you feel about it? The build process is three times faster on a Mac.

@mrruby mrruby requested a review from matthme February 9, 2024 17:44
@matthme
Copy link
Collaborator

matthme commented Feb 9, 2024

What happens here if the rust-utils have changed? Will it always take it from the cache I assume? Another solution would be to publish the rust-utils as an npm package and install it that way.

@matthme
Copy link
Collaborator

matthme commented Feb 9, 2024

Ah - if we change rust-utils we just have to change the version I guess to have it be rebuilt? In that case I think it's a good idea to use the cache.

@mrruby
Copy link
Contributor Author

mrruby commented Feb 9, 2024

Yes it will look at the version of rust-utils

@mrruby mrruby merged commit 4187211 into develop Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants