Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add agent publish #124

Merged
merged 15 commits into from
Feb 21, 2025
Merged

Add agent publish #124

merged 15 commits into from
Feb 21, 2025

Conversation

matthme
Copy link
Contributor

@matthme matthme commented Feb 19, 2025 •
edited
Loading

Resolves the second part of #25 by adding the option to publish agent infos.

@matthme matthme marked this pull request as ready for review February 19, 2025 16:25
@matthme matthme requested a review from a team February 19, 2025 16:26
neonphog
neonphog reviewed Feb 19, 2025
View reviewed changes
neonphog
neonphog requested changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@neonphog neonphog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple suggestions, but looks awesome to me!

neonphog
neonphog previously approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@neonphog neonphog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

jost-s
jost-s previously approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Typo fixes and a trace level.

ThetaSinner
ThetaSinner reviewed Feb 20, 2025
View reviewed changes
Copy link
Member

@ThetaSinner ThetaSinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a question about whether we can make publish_agent private to K2

@matthme matthme enabled auto-merge (squash) February 21, 2025 12:26
@matthme matthme merged commit bf49ba8 into main Feb 21, 2025
7 checks passed
@matthme matthme deleted the feat/add-agent-publish branch February 21, 2025 12:32
@matthme matthme mentioned this pull request Feb 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neonphog neonphog neonphog left review comments

@jost-s jost-s jost-s left review comments

@ThetaSinner ThetaSinner ThetaSinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthme @neonphog @ThetaSinner @jost-s