Dump full state, importing lots of types from https://github.com/holochain-open-dev/core-types #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@guillemcordoba this still under consideration for review? |
|
Yeap! |
jost-s
approved these changes
Jan 12, 2022
There was a problem hiding this comment.
This is brilliant, thanks so much @guillemcordoba !!!
I've included this work into the new repo of the JS client.
|
I'm closing this PR regardless, because we're archiving the repo in favor of the new one. |
|
My mistake, we're not archiving this repo but only changing its name. Regardless, this branch's changes are included. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the effort to make the Holochain Playground compatible with a real Holochain conductor, I've had to create all the types that the
dump_full_statefunction is returning. I thought it would be useful to include them at the @holochain/conductor-api level, so that everyone gets them. Let me know if you'd prefer to keep them at https://github.com/holochain-open-dev/core-types.