Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update msgpack #60

Merged
merged 13 commits into from
Apr 1, 2021
Merged

Update msgpack #60

merged 13 commits into from
Apr 1, 2021

Conversation

zo-el
Copy link
Member

@zo-el zo-el commented Mar 25, 2021 •
edited
Loading

This is what we are seeing in repos like elemental-chat-ui

RROR in ./node_modules/@msgpack/msgpack/dist.es5+esm/Decoder.mjs 202:15-31
Can't import the named export '__asyncGenerator' from non EcmaScript module (only default export is available)
 @ ./node_modules/@msgpack/msgpack/dist.es5+esm/index.mjs
 @ ./node_modules/@holochain/conductor-api/lib/websocket/app.js
 @ ./node_modules/@holochain/conductor-api/lib/index.js
 @ ./build/index.js
 @ ./build/bootstrap.js
 @ multi ./build/bootstrap.js

ERROR in ./node_modules/@msgpack/msgpack/dist.es5+esm/utils/stream.mjs 12:11-27
Can't import the named export '__asyncGenerator' from non EcmaScript module (only default export is available)
 @ ./node_modules/@msgpack/msgpack/dist.es5+esm/decodeAsync.mjs
 @ ./node_modules/@msgpack/msgpack/dist.es5+esm/index.mjs
 @ ./node_modules/@holochain/conductor-api/lib/websocket/app.js
 @ ./node_modules/@holochain/conductor-api/lib/index.js
 @ ./build/index.js
 @ ./build/bootstrap.js
 @ multi ./build/bootstrap.js

Currently pining msgpack to a specific version helps avoid this issue.

@zo-el zo-el requested a review from JettTech March 25, 2021 17:22
Connoropolous
Connoropolous approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@Connoropolous Connoropolous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh brilliant. I just ran into this myself the last few days with acorn and hacked my way through a fix, but this looks much better. We use webpack too so I saw the exact same issue

@timotree3 timotree3 merged commit 3d33e41 into develop Apr 1, 2021
@timotree3 timotree3 deleted the 03-23/msgpack branch April 1, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Connoropolous Connoropolous Connoropolous approved these changes

@JettTech JettTech Awaiting requested review from JettTech

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zo-el @Connoropolous @timotree3