Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update api to include agent inject feature #39

Merged
merged 13 commits into from
Dec 5, 2020
Merged

Conversation

zippy
Copy link
Member

@zippy zippy commented Dec 1, 2020

The PR adds the agent injection that was added to the admin API in holochain/#501

Copy link
Contributor

@Connoropolous Connoropolous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an initial scan...

test/e2e/index.ts Outdated Show resolved Hide resolved
@Connoropolous
Copy link
Contributor

I really like that this is possible now because not only is it good for the test framework, but it will be good for other third party peer discovery solutions and options.

@Connoropolous
Copy link
Contributor

@philipbeadle did the tests pass locally?
CI is failing with:

   can inject agents
    ✔  should be truthy
    ✔  should be truthy
    ✔  should be truthy
    ✖  [object Object] at undefined
        undefinedundefined
        Conductor exited with code null
        Conductor exited with code null

src/api/admin.ts Show resolved Hide resolved
@zippy zippy marked this pull request as ready for review December 4, 2020 23:35
@zippy zippy requested a review from freesig December 4, 2020 23:56
Copy link
Contributor

@freesig freesig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kepp the agent info type opaque because it's not using holochaib types like AgentPubKey it's using kitsune type which you don't have here

src/api/admin.ts Outdated Show resolved Hide resolved
src/api/admin.ts Show resolved Hide resolved
src/api/admin.ts Show resolved Hide resolved
@zippy zippy requested a review from freesig December 5, 2020 13:46
@zippy zippy merged commit 1d52442 into develop Dec 5, 2020
@timotree3 timotree3 deleted the 2020-12-01-agent-inject branch October 29, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants