Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception handlers can be shown more clearly in CFG #42

Open
holly-hacker opened this issue Sep 28, 2020 · 2 comments
Open

Exception handlers can be shown more clearly in CFG #42

holly-hacker opened this issue Sep 28, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@holly-hacker
Copy link
Owner

holly-hacker commented Sep 28, 2020 •
edited
Loading

Some possible improvements to make:

  • Have everything inside a try block as its own BasicBlock, so it can jump out to the exception handler.
  • Use clusters to group everything inside an exception handler try block
@holly-hacker holly-hacker added the bug Something isn't working label Sep 28, 2020
@holly-hacker holly-hacker added this to the v0.5.0 milestone Sep 28, 2020
@holly-hacker
Copy link
Owner Author

Should be respresentable using clusters (sub graphs with borders), as it is within Echo's dot writer

washi image

@holly-hacker
Copy link
Owner Author

Partially fixed so removing from v0.5.0 milestone. Issue now tracks improvements to how exception handlers are displayed.

@holly-hacker holly-hacker removed this from the v0.5.0 milestone Oct 19, 2020
holly-hacker added a commit that referenced this issue Oct 19, 2020
@holly-hacker
Include exception handlers in CIL CFG (see #42)
929243e
@holly-hacker holly-hacker changed the title CFG will not contain exception handlers Exception handlers can be shown more clearly in CFG Oct 19, 2020
@holly-hacker holly-hacker added enhancement New feature or request and removed bug Something isn't working labels Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@holly-hacker