Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new test to self-test for get_url over HTTPS #661

Closed
wants to merge 1 commit into from

Conversation

hollie
Copy link
Owner

@hollie hollie commented Jan 8, 2017

Adds extra test that does a POST request over HTTPS to the MisterHouse selftests.

@hollie
Copy link
Owner Author

hollie commented Jan 10, 2017

Fails on Perl 5.08. Do we still need to support that?

@hollie
Copy link
Owner Author

hollie commented Jan 10, 2017

Going to close and re-open this PR to see if the fail was due to an external reason or not.

@hollie hollie closed this Jan 10, 2017
@hollie hollie reopened this Jan 10, 2017
@hplato
Copy link
Collaborator

hplato commented Feb 20, 2017

This is the only outstanding pull request. I have a perl 5.8.8 machine, and the test seems to work OK for me:

./get_url -post 'testparameter=1' https://httpbin.org/post /tmp/get_url_post_https.txt

Retrieving (with ua) https://httpbin.org/post into /tmp/get_url_post_https.txt ... url retrieved.

cat /tmp/get_url_post_https.txt

{
"args": {},
"data": "",
"files": {},
"form": {
"testparameter": "1"
},
"headers": {
"Content-Length": "15",
"Content-Type": "application/x-www-form-urlencoded",
"Host": "httpbin.org",
"User-Agent": "Mozilla/5.0"
},
"json": null,
"origin": "xx.xx.xx.xx",
"url": "https://httpbin.org/post"
}

perl -v

This is perl, v5.8.8 built for i386-linux-thread-multi

Copyright 1987-2006, Larry Wall

Perl may be copied only under the terms of either the Artistic License or the
GNU General Public License, which may be found in the Perl 5 source kit.

Complete documentation for Perl, including FAQ lists, should be found on
this system using "man perl" or "perldoc perl". If you have access to the
Internet, point your browser at http://www.perl.org/, the Perl Home Page.

@marcmerlin
Copy link
Collaborator

So, is this pull request getting backed out, or fixed and merged?

@hollie
Copy link
Owner Author

hollie commented Aug 15, 2018

I suggest to drop it.

@hollie hollie closed this Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants