-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Razberry - Zwave Lock child object added #566
Conversation
… connection to devices randomly (or at least the single fan device I have)
…ateTime so the pinging could be intelligent. Hopfully a poll cycle ping will keep devices always alive
Made it simpler to add devices for child objects. Will add -0-38 to device ID if not present Refinements to make communication tracker more accurate
Simplified devices, child devices just need the device ID. -0-38 will be appended if not present Refinements to make communication tracker more accurate
This branch has conflicts that must be resolved Could you solve these first so that we can look at a clean diff before merge? |
I'll have the same issue as with venstar. I'm not a git expert so i'm unsure how to continue to contribute? Sent from my mobile device.
|
Same comment here. Check out master, re-apply your patches, delete this pull request, and submit a new one. |
OK, I’m in progress of updating my running with master and trying to figure out how to adapt a bunch of conflict files (those that I’ve modified, but with PerlTidy, the original file has changed so now I’ve got to figure out how to find the actual changes I’ve made, re-apply them against the ‘perltidy’d’ file, and then update. Some short-term pain, but once we’re over this we’ll have a much cleaner codebase...
|
Conflicts: lib/raZberry.pm
Can you look at the latest pull request. I did the following steps
From what I see on the pull request, there is only one changed file, and it looks like only the lock changes. Can someone confirm?
|
I didn't review the actual code, so I'm relying on you to have tested it, but otherwise it looks good. I'll merge. |
Razberry - Zwave Lock child object added
…olortouch Conflicts: lib/Venstar_Colortouch.pm
Tested with a kwikset lock. Basic lock control and battery tracking. Advanced features such as pushing and deleting codes still a WIP.