Insteon Irrigation: Add New Features #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
krkeegan
commented
Jun 13, 2014
krkeegan
commented
- Improved the documentation
- Added support for handling broadcast messages (see documentation)
- Renamed Poll_Valve_Status to Request_Status to match rest of Insteon modules
- Enable functions to Get/Set the various programs on the device
- Add status check timer to check the state of the device if broadcast message is not enabled
- Standardized all routines to use a base index of 1. The sole exception is Program 0
- Add child objects for valves and programs
It is really what the user would expect to recevie for a request_status Sadly, while the device will tell us if a program is running, it doesn't appear that it will tell us WHICH program is running
Partial support was there, but not really enabled.
…t Support Every now and then I am reminded what an AWFUL protocol Insteon is. This is one of them. The EZFlora can be set to send out broadcast messages, however the PLM will not decode them. As a result, MisterHouse never sees them, and they are useless. According to the manual the PLM could be put into monitor mode allowing it to see these messages, however Insteon disabled that feature on the PLM. It is beyond stupid, that the PLM will not display a broadcast message sent from a device in its own link table. There is no security concern here.
… Does not Support" This reverts commit 5528db3. I was a little wrong in my prior assessment. It turns out that with PLM Monitor Mode enabled, I can actually see these messages.
The irrigation broadcast messages are sent whenever the device changes a valve as a result of a timer. To use broadcast messages they must be enabled on the device and the PLM must be put in monitor mode. If a broadcast message is received, it will reset the status_timer and save MH from having to send a valve status request. This results in much more accurate status reports for the valves.
… Timers Printout No Valve 0 - The underlying message structure is odd, sometimes things are indexed from 0 and sometimes from 1. This oddity should not be carried over into the user interface, it only causes confusion.
Makes controlling valves and programs much easier from the web interface and other objects. Also allows the use of generic_items functions such as tie_event
krkeegan
added a commit
that referenced
this pull request
Jun 13, 2014
Insteon Irrigation: Add New Features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.