Insteon: Clear Failure List on Sync/Delete All; Fix Discrepancy with Data3 #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The linkkey contains the data3 value. If the linkkey matches there is no need to check the data3 value. For the PLM data3 is currently ignored because MH sets data3 on responder links to 00, while manually linking sets it to the device's firmware.
krkeegan
added a commit
that referenced
this pull request
Feb 11, 2014
Insteon: Clear Failure List on Sync/Delete All; Fix Discrepancy with Data3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failure list for Sync and Delete all was not being reset on each run. This resulted in subsequent runs reporting problems that did not exist.
The sub PLM::has_link treated Data3 values different than the sub linkkey, this led to a few odd warnings about attempts to add a link that already exists.