PA control enhancements #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed zone types, tested X10, xPL, xAP, object and wdio. xPL and xAP were only tested to send to the designated IP address - verified with netcat on target computer.
…ng cepstral swift for voice
…ze on arrow notation for parms.
…they were on before starting speech.
…oneous code comment.
…eaks more reliably in desired rooms, due to correcting a race condition.
|
Steve, same thing with this request too. Can you confirm its stabilty? Also, I suspect there is a conflict with the other speech commit that I just merged. If you merge master into this branch you can fix the conflicts. |
Conflicts: lib/read_table_A.pl
|
Wow, just saw this comment too... Yes, I feel it's stable, and I already merged without noticing your comment. LOL |
…ents, rather than the index of the last element. (index 0 = element 1)
|
Did a little housekeeping to make me more comfortable with a merge. Tests good on two machines. |
…multiple speaker out channels to be used as separate PA rooms.
Added Alsa support to allow different sound card channels to be PA rooms through amixer in Linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated PAObj and pa_control to allow for a mix of different zone types and added a new zone type of "object". You can now use an existing object as a PA zone or a member of a group if it accepts ON and OFF commands via set. I tested this by using an Insteon object.
This could be used to turn on a device or lamp while MH is speaking. Perhaps an animated head just for fun! More practically, an IOLINC could be used to turn on a remote speaker. Scenes should work as well.
The on thing that I'm not sure how to handle long term is the extra delay in turning things on when there are multiple devices to send commands to. There could be X10, Insteon, weeder and other devices that are all sent messages. The io device, amp or whatever should confirm that they're on before the audio is sent, or we may miss the first part if the PLM is busy. Either way, this is a step in the right direction.