Insteon: Move Failure_Reason into BaseObject from Message #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The active_message must be cleared before calling the failure_callback, otherwise we get into a strange loop with sync and scan links Once the active_message is cleared, we lose our ability to keep track of the failured message and corresponding failure_reason To resolve this, moved failure_reason from the message object into BaseObject.
krkeegan
added a commit
that referenced
this pull request
May 21, 2013
Insteon: Move Failure_Reason into BaseObject from Message
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The active_message must be cleared before calling the failure_callback, otherwise we get into a strange loop with sync and scan links
Once the active_message is cleared, we lose our ability to keep track of the failured message and corresponding failure_reason
To resolve this, moved failure_reason from the message object into BaseObject.