Fix issue 158 #159
Merged
Fix issue 158 #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PLM may report a busy code 15, even when there is no active_message. Added logic to test for an active message before trying to resend it. Partial fix for issue hollie#154
…tive Message I am not clear how this could be occuring, but it was reported as a crash. Added simple logic to test for an active_message before trying to call the active message. Fixes Issue hollie#154
Solves issue hollie#158 identified by Chris Dragon This will trim the leading "15" bytes from the data. If anything is left it will be placed into the message fragment to be read next time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problem where the read buffer was cleared whenever a NACK busy message was present. This patch will trim the leading "15" byte(s) and if anything remains it will push it into the fragment for the next read.
Fixes #158
This pull intentionally relies on pull request #155. Since adjacent code was changed, pull request #155 should be merged first and then this request. I apologize that it makes this pull request more difficult to read. The only additional change is the last commit, so if you review those changes it will be easier to understand.