Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POD updates lib/A*~L*.pm #118

Merged
merged 1 commit into from
Apr 14, 2013
Merged

POD updates lib/A*~L*.pm #118

merged 1 commit into from
Apr 14, 2013

Conversation

drobinson0919
Copy link
Contributor

Updated POD with new formatting to support all docs on one page, nicer TOC, more consistent layout: (did not touch any Insteon items as i believe those are being worked on)

=head1 NAME
B<package_name>
changed to:
=head1 B<package_name

also all other =head1 changed to =head2

Corrected formatting on =items for better output

=item C - description
changed to:
=item C
description
=cut

Reviewed all docs for consistency

@mstovenour
Copy link
Collaborator

Would you mind creating a page linked to http://misterhouse.wikispaces.com/Coding+Best+Practices that describes the "format" you used for all these updates? I'll just call that the "right" format for now and copy it anytime I add a new function.

@mstovenour
Copy link
Collaborator

Have you run perldoc and podchecker on each of these files to make sure the output is as you intended? I saw some places where it looks like you had intended to use a new-line to format a section. I sure you know that a single new-line is eaten by the pod format programs. Where a single new-line is normally used you need to add a blank line. I know you know all this, I'm just wondering if you looked at each change through perldoc to make sure it worked out the way you intended.

@drobinson0919
Copy link
Contributor Author

I would not mind however I do not have access to the wiki. I am a member
but do not have perms to edit.

Beyond that I though we were taking all the documentation into the source
code so that it was accessible to everyone. I would be more than willing
to POD the aforementioned pages in the docs/ directory.

On Sun, Mar 17, 2013 at 1:05 PM, Michael Stovenour <[email protected]

wrote:

Would you mind creating a page linked to
http://misterhouse.wikispaces.com/Coding+Best+Practices that describes
the "format" you used for all these updates? I'll just call that the
"right" format for now and copy it anytime I add a new function.


Reply to this email directly or view it on GitHubhttps://github.com//pull/118#issuecomment-15026338
.

@drobinson0919
Copy link
Contributor Author

I have run pocchecker as well as run the entire lib/ directory through
pod2html to view the output.

I am aware that a single newline is dropped in the conversion. I have made
all the corrections that I saw. That said that was about 4k lines of
comments moved around. If i missed one i'm sorry. If i catch it in the
future I will make corrections.

-D

On Sun, Mar 17, 2013 at 3:40 PM, Dustin Robinson [email protected] wrote:

I would not mind however I do not have access to the wiki. I am a member
but do not have perms to edit.

Beyond that I though we were taking all the documentation into the source
code so that it was accessible to everyone. I would be more than willing
to POD the aforementioned pages in the docs/ directory.

On Sun, Mar 17, 2013 at 1:05 PM, Michael Stovenour <
[email protected]> wrote:

Would you mind creating a page linked to
http://misterhouse.wikispaces.com/Coding+Best+Practices that describes
the "format" you used for all these updates? I'll just call that the
"right" format for now and copy it anytime I add a new function.


Reply to this email directly or view it on GitHubhttps://github.com//pull/118#issuecomment-15026338
.

@mstovenour
Copy link
Collaborator

Ok. I didn’t see anything major. I was trying to reverse engineer your format for a new Insteon function I’m writing and saw a few cases that made me wonder if you had proofread the output. No big deal.

From: drobinson0919 [mailto:[email protected]]
Sent: Sunday, March 17, 2013 2:44 PM
To: hollie/misterhouse
Cc: Michael Stovenour
Subject: Re: [misterhouse] POD updates lib/A_~L_.pm (#118)

I have run pocchecker as well as run the entire lib/ directory through
pod2html to view the output.

I am aware that a single newline is dropped in the conversion. I have made
all the corrections that I saw. That said that was about 4k lines of
comments moved around. If i missed one i'm sorry. If i catch it in the
future I will make corrections.

-D

@drobinson0919
Copy link
Contributor Author

Where were the ones you saw? I am trying to be thorough but there are lots of lines and im bound to miss some.

@drobinson0919
Copy link
Contributor Author

Is there something wrong with these updates or is there something I should be doing?

@mstovenour
Copy link
Collaborator

I for one was waiting until we are about to release 3.0 to merge these. There is little logic in that decision; mostly just laziness.

hollie added a commit that referenced this pull request Apr 14, 2013
@hollie hollie merged commit 5137a0b into hollie:master Apr 14, 2013
@hollie
Copy link
Owner

hollie commented Apr 14, 2013

Sorry it took so long. Busy with other projects...

@drobinson0919
Copy link
Contributor Author

Please don't be sorry. I was just wondering if I had done something
incorrectly
On Apr 14, 2013 1:46 PM, "Lieven Hollevoet" [email protected]
wrote:

Sorry it took so long. Busy with other projects...


Reply to this email directly or view it on GitHubhttps://github.com//pull/118#issuecomment-16355718
.

@hollie hollie mentioned this pull request Jun 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants