Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insteon: Delete Orphan Links Log is Out of Sequence #61

Closed
krkeegan opened this issue Feb 7, 2013 · 0 comments
Closed

Insteon: Delete Orphan Links Log is Out of Sequence #61

krkeegan opened this issue Feb 7, 2013 · 0 comments
Assignees
@krkeegan
Labels
bug

Comments

@krkeegan
Copy link
Collaborator

krkeegan commented Feb 7, 2013

It appears that the calls to delete_links and the traversing of the devices are being handled concurrently rather than sequentially. As a result, a psuedo log sequence looks like this:

Checking Device A for orphan links
Checking Device B for orphan links
Orphan link found on Device B
Checking Device C for orphan links
Checking Device D for orphan links
Orphan Links complete 1 link deleted
Deleting orphan link on Device B
Orphan Links complete 2 links deleted
@ghost ghost assigned krkeegan Feb 7, 2013
krkeegan added a commit to krkeegan/misterhouse that referenced this issue Feb 8, 2013
@krkeegan
Fix Error in Delete Orphans which Caused Process to Occur Out of Sequ…
a1d856e 
…ence

Remove message callback from PLM Delete_Link and insert ALDB_Callback in Insteon_PLM.

Message callback is called as soon as the message is sent, and then it was again called on receiving the ACK.  Which resulted in at least two instances of Delete Orphans running.

Fix hollie#61
@krkeegan krkeegan mentioned this issue Feb 8, 2013
Merged
@krkeegan krkeegan closed this as completed Feb 8, 2013
@krkeegan krkeegan mentioned this issue Feb 21, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krkeegan krkeegan

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@krkeegan