-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update_docs complains under windows #234
Comments
Hmm, well we could take the simple way out and just compare the paths, if they match we give the error? I can't think of a way to get the benefits of matching an inode number without using an inode number. |
Yeah this old perl monks topic seems to confirm that the functionality we seek is not available in the base install of perl for windows. One entry suggests delving into the Win32::API class, but I am not very excited about that idea. |
If inode==0 then we are probably on windows, so use abs_path to compare the two paths and see if they are the same. I don't have windows so hopefully this works. Fixes hollie#234
Michael, can you test this and see if this fixes the glitch? |
Thanks! This works in both Linux and Windows. In windows I tested three cases. 1) html_alias2_docs not specified (received warning), 2) html_alias2_docs specified but ultimately pointing to the mh installation path (received warning), and 3) html_alias2_docs pointing outside the mh installation path (did not receive warning). |
The pull request for issue #199 has a subtle bug under windows. It will always complain about setting the html_alias2_docs directory to a place outside the mh distribution. Apparently the stat() function always returns inode==0 on windows. Maybe there is a simpler, all be it less reliable, way to make this check.
The text was updated successfully, but these errors were encountered: