Insteon: MH Should React to AllLink Broadcast Messages

[krkeegan]

Currently MH ignores the AllLink Broadcast message knowing that a direct-cleanup message containing the same information will arrive shortly thereafter. Unfortunately, the direct-cleanup messages are lost sometimes. Moreover, in a large scene, it may take many seconds for the direct-cleanup message to arrive and so it may be preferable for MH to react to the broadcast message to be more "in-sync" with the timing of things.

Some consideration should be given to preventing duplicate calls to set the state of the device. Perhaps a flag that tracks the time when an alllink broadcast message is received and if a matching direct-cleanup message is received within a specified number of seconds no subsequent call to the set routine is made?

[mstovenour]

I think the code for processing the second event (i.e. direct-cleanup) could just compare the current state to the new state and only update if the two do not match. Effectively “state” is the flag you describe.

[krkeegan]

I thought about that, but it would create the possibility of a quirk.
Normally pressing the 'on' button on a device would still set state_now
for one loop even if the light was already on. But, if the broadcast
message was missed, state_now would not be set. Maybe I could check the
idle_time and if it is less than __ seconds we assume a broadcast was
received?? However, really large scenes could take many seconds to complete.

So two options:

1. Accept an strange anomaly in what seems like a rare case
2. Add yet another flag

Neither are ideal, what do you think?

On Sun, Apr 7, 2013 at 7:06 AM, Michael Stovenour
[email protected]:

I think the code for processing the second event (i.e. direct-cleanup)
could just compare the current state to the new state and only update if
the two do not match. Effectively “state” is the flag you describe.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/153#issuecomment-16015646
.