Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for junit4 #335

Closed
jangalinski opened this issue Sep 21, 2023 · 1 comment · Fixed by #336
Closed

Drop support for junit4 #335

jangalinski opened this issue Sep 21, 2023 · 1 comment · Fixed by #336
Assignees
@jangalinski
Labels
Type: enhancement New feature or request
Milestone
4.8.0.0

Comments

@jangalinski
Copy link
Contributor

We have a dedicated module to support axon, jgiven and junit4.

As junit5 is completely established everywhere, we should drop this ... especially as we have an asymetry ... upcaster testing does not support junit4, so it is either dropping for jgiven or establishing for upcasters.
@jangalinski jangalinski self-assigned this Sep 21, 2023
@jangalinski jangalinski added this to the 4.8.3.0 milestone Sep 21, 2023
@jangalinski jangalinski added the Type: enhancement New feature or request label Sep 21, 2023
jangalinski added a commit that referenced this issue Sep 21, 2023
@jangalinski
drop junit 4 modules, fixes #335
8d347f4
@jangalinski jangalinski mentioned this issue Sep 21, 2023
Merged
@zambrovski
Copy link
Contributor

Just drop it.

@zambrovski zambrovski modified the milestones: 4.8.3.0, 4.7.6.0 Sep 21, 2023
@zambrovski zambrovski modified the milestones: 4.7.6.0, 4.8.3.0 Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jangalinski jangalinski

Labels
Type: enhancement New feature or request
Projects
None yet
Milestone
4.8.0.0
Development

Successfully merging a pull request may close this issue.

drop junit 4 modules holixon/axon-testing
2 participants
@zambrovski @jangalinski