Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: db2dbml bigquery connector's query #660

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

kenzht
Copy link
Contributor

@kenzht kenzht commented Nov 20, 2024

Summary

Issue

#659

Lasting Changes (Technical)

(please list down: code changes/things that have wide-effect; new libraries/functions added that can be used by others; examples below)

  • fixed the column name used in BigQuery query.

Checklist

Please check directly on the box once each of these are done

  • Documentation (if necessary)
  • Tests (integration test/unit test)
  • Integration Tests Passed
  • Code Review

@nguyenalter nguyenalter added the PR: Bug Fix 🐛 A type of pull request used for changelog categories label Nov 20, 2024
@huyleminh01 huyleminh01 added the bug Something isn't working label Nov 20, 2024
Copy link
Contributor

@huyleminh01 huyleminh01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me.

Thank you for fixing this typo.

@huyleminh01 huyleminh01 merged commit dc42d97 into holistics:master Nov 20, 2024
1 of 2 checks passed
@huyleminh01 huyleminh01 mentioned this pull request Dec 5, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PR: Bug Fix 🐛 A type of pull request used for changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

db2dbml BigQuery fails with Name create_time not found inside t
3 participants