Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Snowflake connector #623

Merged
merged 15 commits into from
Aug 27, 2024
Merged

Add Snowflake connector #623

merged 15 commits into from
Aug 27, 2024

Conversation

huyphung1602
Copy link
Collaborator

Summary

  • Add Snowflake connector

Issue

(issue link here)

Lasting Changes (Technical)

  • Add Snowflake connector
  • Allow users to select schema when fetching schema information from: Postgresql, Mysql, MSSQL, and Snowflake.

Checklist

Please check directly on the box once each of these are done

  • Documentation (if necessary)
  • Tests (integration test/unit test)
  • Integration Tests Passed
  • Code Review

@huyphung1602
Add ddl sample for Snowflake database
c95b070
@huyphung1602
Add snowflake-sdk package:
39f9707 
- Fix the issues in the Snowflake DDL
- Add the draft connector for Snowflake database
@huyphung1602
The very first code that work to fetch tables and fields
d6d562c
@huyphung1602
Support fetching tables and fields and convert to DBML
20d3870 
- Add log level configs: LOG_LEVEL and IS_DEBUG_MODE
- Reduce the number of retries to three
- Set the timeout to 10000
- Add SCHEMA= to select schema
- Replace undefined type to the matching column types
- Add the default values if any
@huyphung1602
Wrap up the Snowflake connector
6c26bb8 
- Add the description for Snowflake Connector
- Update the identity constraint of each table (pk)
- Add pk? and unique? to Field type in dbml/connector
@huyphung1602
Support primary and unique constraints
bbcdb91
@huyphung1602
Support selecting multiple schemas for Snowflake
1383d84
@huyphung1602
Fix special case when schema contains comma
0a7c597
@huyphung1602
Remove redundant logs
80ba9cc
@huyphung1602
Allow postgres connector to select schemas
0d8dbaf 
- Add function to parse schemas syntax from postgres connection string
- Add schemas query into PostgreSQL queries
- Fix bug when database have more than one schema
@huyphung1602
Rename format keyword to database-type
a228d59
@huyphung1602
Allow mssql to select schemas
7d5db4a 
- Add code to parse schemas for odbc
- Add schemas sql into queries
- Refactor parseSchema utils
- Fix issue when there are multiple schemas inside mssql
@huyphung1602
Fix bearer
8d863b1
huyleminh01
huyleminh01 approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@huyleminh01 huyleminh01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huyphung1602 huyphung1602 merged commit 17f38c8 into master Aug 27, 2024
3 checks passed
@huyphung1602 huyphung1602 deleted the add-snowflake-connector branch August 27, 2024 05:43
@huyleminh01 huyleminh01 added the PR: New Feature 🚀 A type of pull request used for changelog categories label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huyleminh01 huyleminh01 huyleminh01 approved these changes

@NQPhuc NQPhuc Awaiting requested review from NQPhuc

Assignees
No one assigned
Labels
PR: New Feature 🚀 A type of pull request used for changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huyphung1602 @huyleminh01