Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure and normalize models; add Project, Note and multi-line string #47

Merged
merged 39 commits into from
Feb 27, 2020
Merged

Restructure and normalize models; add Project, Note and multi-line string #47

merged 39 commits into from
Feb 27, 2020

Conversation

phuongduyphan
Copy link
Collaborator

@phuongduyphan phuongduyphan commented Dec 16, 2019 •
edited
Loading

Summary

  • Added database model
  • Updated new doc img

DBML AST Normalized Format

Issue

Lasting Changes (Technical)

  • Added Database class
  • Changed processing flow of models
  • Normalized model objects
  • Added and modified test cases
  • Handled multiple schemas business logic (not parse the schema syntax yet).
  • Changed APIs of Parser, replaced SchemaExporter with ModelExporter.
  • Support multi-line string
  • Support Note syntax for DBML Elements
  • Support Project syntax

Checklist

Please check directly on the box once each of these are done

  • Documentation (if necessary)
  • Tests (integration test/unit test)
  • Integration Tests Passed
  • Code Review

@phuongduyphan phuongduyphan added PR: Breaking Change 💥 A type of pull request used for changelog categories pkg: core labels Dec 16, 2019
@phuongduyphan phuongduyphan force-pushed the dbml-core/add-database branch from 417b222 to 08c1e34 Compare January 5, 2020 15:31
@phuongduyphan phuongduyphan changed the title Restructure and normalize models Restructure and normalize models, support Project, Note, multi-line string syntaxes Feb 27, 2020
@phuongduyphan phuongduyphan changed the title Restructure and normalize models, support Project, Note, multi-line string syntaxes Restructure and normalize models; add Project, Note, multi-line string Feb 27, 2020
@phuongduyphan phuongduyphan changed the title Restructure and normalize models; add Project, Note, multi-line string Restructure and normalize models; add Project, Note and multi-line string Feb 27, 2020
@phuongduyphan phuongduyphan merged commit 166e4bb into master Feb 27, 2020
@phuongduyphan phuongduyphan added PR: New Feature 🚀 A type of pull request used for changelog categories PR: Docs 📝 A type of pull request used for changelog categories labels Feb 27, 2020
phuongduyphan added a commit that referenced this pull request Feb 27, 2020
@phuongduyphan
Revert "Restructure and normalize models; add Project, Note and multi…
8973ec3 
…-line string (#47)"

This reverts commit 166e4bb.
This was referenced Jul 27, 2021
Closed
Closed
Closed
@coderabbitai coderabbitai bot mentioned this pull request Apr 25, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khoahuynhdev khoahuynhdev khoahuynhdev approved these changes

Assignees
No one assigned
Labels
pkg: core PR: Breaking Change 💥 A type of pull request used for changelog categories PR: Docs 📝 A type of pull request used for changelog categories PR: New Feature 🚀 A type of pull request used for changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phuongduyphan @khoahuynhdev