Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rs] change 9th of May dan pobede to informal holiday #230

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

KristjanSever
Copy link
Contributor

9th of May (dan pobede) is not a work free day. I didnt find any information on whether or not this should count as a holiday or not (also checked some other countries to see if there are similar occurences but I didnt find any) or what a holiday means in the context of this PR. If i made a mistake please say so.

How i percieved this repository is to allow developers to easily distinguish between working days and non working ones. Since 9th of May is not a work free day I propose to have it marked as an informal holiday.

╰─➤  make                                                                                                                                                                                                                                                                                              
bundle exec ruby lib/validation/run.rb
Success!
Definition count: 73

@KristjanSever KristjanSever changed the title change 9th of May dan pobjede to informal holiday change 9th of May dan pobede to informal holiday Aug 24, 2022
@KristjanSever KristjanSever changed the title change 9th of May dan pobede to informal holiday [rs] change 9th of May dan pobede to informal holiday Sep 1, 2022
Copy link
Member

@ppeble ppeble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This all looks good to me.

@ppeble ppeble merged commit 6b0beb8 into holidays:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants