Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add UUPS upgradable proxy contract #121

Merged
merged 7 commits into from
Jan 11, 2024
Merged

feat: add UUPS upgradable proxy contract #121

merged 7 commits into from
Jan 11, 2024

Conversation

call3hudson
Copy link
Contributor

Use an Upgradable Proxy Pattern

What I did in this PR

  1. Updated the contract to UUPS upgradable and added relevant test cases and deployment scripts
  2. Fixed one test case for claiming pending payment
  3. Refactored all the scripts to typescript

@call3hudson
feat: uups-contract-done
58d6973 
(cherry picked from commit 1389d8aed0251e82e9b1ad38020d8e6adb0851bc)
@call3hudson
feat: proxy-deployment-script-done, refactor-scripts-to-typescript
102bdf8 
(cherry picked from commit 8e40879f498639c052057b769f64380f396c7592)
@call3hudson
fix: test-case-for-claiming-pending-money
4fecf96 
(cherry picked from commit 300c1708d69b1b70713bf79f969c035c0bcefb81)
georgeciubotaru
georgeciubotaru reviewed Jan 10, 2024
View reviewed changes
hardhat.config.ts Outdated Show resolved Hide resolved
georgeciubotaru
georgeciubotaru requested changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@georgeciubotaru georgeciubotaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the comments, above, you've done a great job 👍

@markholdex
Copy link
Contributor

@call3hudson 👍 Please check my Discord messages. Thanks!

@georgeciubotaru
Copy link
Contributor

@call3hudson See the unresolved comments

@call3hudson
Copy link
Contributor Author

@call3hudson See the unresolved comments

@georgeciubotaru Removed, Please check

georgeciubotaru
georgeciubotaru requested changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@georgeciubotaru georgeciubotaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve the tests issues

@georgeciubotaru
Copy link
Contributor

image

@call3hudson
Copy link
Contributor Author

please resolve the tests issues

This can be resolved by using yarn install as you know so maybe changing the workflow would be perfect
But if you are keen on npm install I will work on that(guess need some hours to work on it)

georgeciubotaru
georgeciubotaru reviewed Jan 10, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@georgeciubotaru georgeciubotaru merged commit a6ad7fb into holdex:main Jan 11, 2024
1 check passed
@georgeciubotaru georgeciubotaru linked an issue Jan 15, 2024 that may be closed by this pull request
Use an Upgradable Proxy ERC1155 to deploy each new StreamManager contract #117
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgeciubotaru georgeciubotaru georgeciubotaru approved these changes

Assignees

@georgeciubotaru georgeciubotaru

@call3hudson call3hudson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use an Upgradable Proxy ERC1155 to deploy each new StreamManager contract
3 participants
@call3hudson @markholdex @georgeciubotaru