Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch CLI from Click to Typer #131

Merged
merged 5 commits into from
Jan 6, 2024
Merged

Switch CLI from Click to Typer #131

merged 5 commits into from
Jan 6, 2024

Conversation

hoechenberger
Copy link
Owner

No description provided.

@hoechenberger
Copy link
Owner Author

hoechenberger commented Jan 5, 2024

Screenshot 2024-01-05 at 08 10 59 Screenshot 2024-01-05 at 08 12 22

@larsoner WDYT? Looks good, no? :)

@hoechenberger hoechenberger marked this pull request as ready for review January 5, 2024 07:23
@agramfort
Copy link
Collaborator

It looks as good on windows ?

@hoechenberger
Copy link
Owner Author

@agramfort Typer is supposed to support Windows consoles out of the box; I haven't tested on Windows myself, but the CI output looks good:

Screenshot 2024-01-05 at 08 54 11

I'm not sure which shell this is using, though 🤔
Do you have any chance to test on Windows?

It's using rich under the hood, which claims to work with CMD and the Windows Terminal:
https://rich.readthedocs.io/en/stable/introduction.html#requirements

So I'm not too concerned, but it would be great if we could actually test it!

@agramfort
Copy link
Collaborator

agramfort commented Jan 5, 2024 via email

@sappelhoff
Copy link

looks pretty and seems to work on Windows 11 just as advertised (using a pip install in a conda env):

on powershell:

image

on "command prompt" (cmd)

image

@hoechenberger
Copy link
Owner Author

Thanks for testing this, @sappelhoff!

@hoechenberger hoechenberger merged commit 0dacf80 into main Jan 6, 2024
6 checks passed
@hoechenberger hoechenberger deleted the typer branch January 6, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants