399 migrate to esmodules #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AdvancedCodingMonkey
changed the base branch from
master
to
412-set-up-testing-infrastructure
Closed
AdvancedCodingMonkey
force-pushed
the
399-migrate-to-esmodules
branch
from
c0d78e3 to
88e145e
Compare
AdvancedCodingMonkey
force-pushed
the
399-migrate-to-esmodules
branch
from
88e145e to
aba39cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here was to use es modules for the project by switching from
type: commonjstotype: modulein the package.json. This produced some conflicts however, so I had to fiddle around somewhat until I found a solution that worked. In the process, I removed themonkey-patchscript, as the warnings it was suppressing were not present anymore.