chore-395: fix deepscan warnings

hodcroftlab · Nov 27, 2024 · badaf13 · badaf13
1 parent da7ea3d
commit badaf13
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/web/src/components/Common/NextstrainLogo.tsx b/web/src/components/Common/NextstrainLogo.tsx
@@ -38,7 +38,7 @@ const LetterSpan = styled.span<{ pos: number }>`
 
 export function NextstrainLogo() {
   return (
-    (<Wrapper>
+    <Wrapper>
       <NextstrainIcon />
       <span>
         {'Nextstrain'.split('').map((letter, i) => (
@@ -48,6 +48,6 @@ export function NextstrainLogo() {
           </LetterSpan>)
         ))}
       </span>
-    </Wrapper>)
+    </Wrapper>
   );
 }
diff --git a/web/src/components/Link/Link.tsx b/web/src/components/Link/Link.tsx
@@ -8,9 +8,9 @@ export interface LinkProps extends PropsWithChildren<NextLinkProps & HTMLAttribu
 
 export function Link({ className, children, href, ...restProps }: LinkProps) {
   return (
-    (<NextLink href={href} passHref={false} className={className}>
+    <NextLink href={href} passHref={false} className={className}>
       {/* eslint-disable-next-line jsx-a11y/anchor-is-valid */}
       {children}
-    </NextLink>)
+    </NextLink>
   );
 }
diff --git a/web/src/components/Variants/ProteinCard.tsx b/web/src/components/Variants/ProteinCard.tsx
@@ -3,14 +3,15 @@ import React, { useCallback, useEffect, useMemo, useState } from 'react'
 import styled from 'styled-components'
 import { SiMoleculer } from 'react-icons/si'
 import { Card, CardBody, CardHeader, Col, Container, Row } from 'reactstrap'
+import Image from 'next/image'
 
 import { URL_GITHUB } from 'src/constants'
 import { useTranslationSafe } from 'src/helpers/useTranslationSafe'
 import type { ClusterDatum } from 'src/io/getClusters'
 import { LinkExternal } from 'src/components/Link/LinkExternal'
 import GifPlayer from 'src/components/Common/GifPlayer'
 
-import GisaidLogo from 'src/assets/images/GISAID_logo.svg'
+import GisaidLogo from 'src/assets/images/GISAID_logo.png'
 
 const ProteinCardTitleIcon = styled(SiMoleculer)`
   margin: auto 5px;
@@ -142,7 +143,7 @@ export function ProteinCard({ cluster }: ProteinCardProps) {
                 {'. '}
                 {t('Figure made via {{source}}', { source: '' })}
                 <LinkExternal href="https://www.gisaid.org/" icon={null}>
-                  <GisaidLogo className="my-auto" height={18} />
+                  <Image src={GisaidLogo} alt='GISAID' className={"my-auto"} height={18} width={49}/>
                 </LinkExternal>
               </small>
             </figcaption>