Skip to content

Commit

Permalink
chore-395: address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Simon Füting committed Nov 29, 2024
1 parent e003380 commit 3258f11
Show file tree
Hide file tree
Showing 24 changed files with 900 additions and 911 deletions.
4 changes: 2 additions & 2 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ updates:
schedule:
interval: 'weekly'
milestone: 1
- package-ecosystem: 'yarn'
- package-ecosystem: 'npm'
directory: "/web"
schedule:
interval: 'weekly'
Expand All @@ -20,4 +20,4 @@ updates:
labels:
- 'python'
- 'dependencies'
milestone: 1
milestone: 1
19 changes: 10 additions & 9 deletions web/next.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ import { uniq } from 'lodash'
import getWithMDX from '@next/mdx'
import withPlugins from 'next-compose-plugins'
import getWithTranspileModules from 'next-transpile-modules'
import remarkToc from 'remark-toc';
import remarkSlug from 'remark-slug';
import remarkBreaks from 'remark-breaks';
import remarkImages from 'remark-images';
import remarkMath from 'remark-math';
import remarkToc from 'remark-toc'
import remarkSlug from 'remark-slug'
import remarkBreaks from 'remark-breaks'
import remarkImages from 'remark-images'
import remarkMath from 'remark-math'

import { findModuleRoot } from './lib/findModuleRoot'
import { getGitBranch } from './lib/getGitBranch'
Expand Down Expand Up @@ -98,19 +98,20 @@ const nextConfig: NextConfig = {
},
sassOptions: {
includePaths: ['node_modules'], // the correct option should be loadPaths but somehow that does not work (yet)
// TODO: remove this silencing once bootstrap has applied SASS API changes (https://github.com/hodcroftlab/covariants/issues/402)
// There are a lot of warnings coming from SASS API changes that bootstrap has not implemented, silencing those
// However, this might mask warnings from our own code, so be sure to check from time to time. `quietDeps` seems to
// not work completely as intended.
quietDeps: true,
silenceDeprecations: ['mixed-decls', 'color-functions', 'legacy-js-api', 'global-builtin', 'import'],
},
output: 'export', // TODO: with the cli command, two threads were used here, no idea how to do it with this config option
output: 'export', // TODO: with the cli command, two threads were used here, no idea how to do it with this config option.
// TODO: images option is needed because of static export
// (https://nextjs.org/docs/app/building-your-application/deploying/static-exports#image-optimization);
// can be removed, once the GISAID svg logo works again
// can be removed, once the GISAID svg logo works again (https://github.com/hodcroftlab/covariants/issues/398)
images: {
unoptimized: true
}
unoptimized: true,
},
}

const withMDX = getWithMDX({
Expand Down
Loading

0 comments on commit 3258f11

Please sign in to comment.