Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(combine): add combine versions for 6-12 Flows #113

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Conversation

hoc081098
Copy link
Owner

Closes #78

Status

READY

Breaking Changes

NO

Description

feat(combine): add combine versions for 6-12 Flows

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Requirements

  • Dump api
  • Update README
  • Update CHANGELOG
  • Add tests
  • Add docs

@hoc081098 hoc081098 added this to the 0.4.0 milestone Jul 15, 2022
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #113 (8126624) into master (99c375d) will decrease coverage by 10.28%.
The diff coverage is 38.88%.

@@             Coverage Diff             @@
##           master     #113       +/-   ##
===========================================
- Coverage   83.68%   73.40%   -10.29%     
===========================================
  Files          26       27        +1     
  Lines         423      549      +126     
  Branches       68       75        +7     
===========================================
+ Hits          354      403       +49     
- Misses         46      116       +70     
- Partials       23       30        +7     
Impacted Files Coverage Δ
...commonMain/kotlin/com/hoc081098/flowext/combine.kt 38.88% <38.88%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3f7dd0...8126624. Read the comment docs.

@hoc081098 hoc081098 merged commit 7ccf91d into master Jul 15, 2022
@hoc081098 hoc081098 deleted the combine branch July 15, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

defer, skipUntil & combine
1 participant