Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for no_std gated by not(test) #38

Merged
merged 4 commits into from
Jun 27, 2019
Merged

Conversation

xoloki
Copy link
Contributor

@xoloki xoloki commented Jun 7, 2019

The no_std check in main files does not catch the case where the no_std is gated on not(test). This change adds that check before failing with SourceOffense::MissingNoStdAttribute.

This fixes a false positive with the widely used clear_on_drop crate, which prevents using cargo nono in CI for crates which depend on clear_on_drop.

@hobofan hobofan self-requested a review June 8, 2019 08:19
@hobofan
Copy link
Owner

hobofan commented Jun 8, 2019

Thanks for the contribution! 👏

It would be great if you can add a test case for that. For that you can just copy one of the projects in the test directory and adjust it.

I'll also have to change the CI here to ignore the Linux build for the time being, as it's broken right now. (#37)

@xoloki
Copy link
Contributor Author

xoloki commented Jun 13, 2019

Okay @hobofan, I added a test for the new behavior copied from an existing test. The new test is succeeding on the macos platform.

Let me know if there's anything else you want me to do.

@xoloki
Copy link
Contributor Author

xoloki commented Jun 20, 2019

I updated CI to disable the linux builds as per issue #37 @hobofan. CI is now passing. There was a weird file locking error the first time CI ran, but after triggering a second build it succeeded, so I think the error was spurious.

Let me know if there's anything else you want me to do.

@hobofan
Copy link
Owner

hobofan commented Jun 27, 2019

LGTM 👍

Thanks for the patience!

@hobofan hobofan merged commit f55454a into hobofan:master Jun 27, 2019
@hobofan
Copy link
Owner

hobofan commented Jun 27, 2019

Released in 0.1.5!

@xoloki
Copy link
Contributor Author

xoloki commented Jun 28, 2019

Excellent, thanks @hobofan!

I noticed that cargo install cargo-nono is still picking up v1.1.4, do you have any idea what needs to happen for the release to propagate?

@xoloki
Copy link
Contributor Author

xoloki commented Jun 28, 2019

I emailed [email protected] to ask them to update the index. Hopefully that should take care of it.

@hobofan
Copy link
Owner

hobofan commented Jun 29, 2019

Sorry, I had only published it as a binary via Github Releases 🙈. Should be on crates.io now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants