-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for no_std gated by not(test) #38
Conversation
Thanks for the contribution! 👏 It would be great if you can add a test case for that. For that you can just copy one of the projects in the test directory and adjust it. I'll also have to change the CI here to ignore the Linux build for the time being, as it's broken right now. (#37) |
Okay @hobofan, I added a test for the new behavior copied from an existing test. The new test is succeeding on the macos platform. Let me know if there's anything else you want me to do. |
LGTM 👍 Thanks for the patience! |
Released in |
Excellent, thanks @hobofan! I noticed that |
I emailed |
Sorry, I had only published it as a binary via Github Releases 🙈. Should be on crates.io now. |
The no_std check in main files does not catch the case where the no_std is gated on not(test). This change adds that check before failing with SourceOffense::MissingNoStdAttribute.
This fixes a false positive with the widely used clear_on_drop crate, which prevents using cargo nono in CI for crates which depend on clear_on_drop.