Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for custom OIDC providers to set up authentication #92 #307

Merged
merged 10 commits into from
Sep 15, 2024

Conversation

kamtschatka
Copy link
Contributor

Added support for custom OIDC providers to set up authentication

I tried it with Google and Authentik and it worked great.
Only thing missing is showing the error message in "apps/web/components/signin/SignInForm.tsx", but I failed to do so, since it is a server side rendered component and I was not able to get the "error" parameter from the querystring and show it on screen.

Added support for custom OIDC providers to set up authentication
@kamtschatka kamtschatka changed the title https://github.com/hoarder-app/hoarder/issues/92 Added support for custom OIDC providers to set up authentication #92 Jul 15, 2024
@winston0410
Copy link

I want to manage my account in Hoarder through OIDC as well, and this PR looks good. Do we know what is blocking this PR?

@MohamedBassem
Copy link
Collaborator

@winston0410 Nothing is blocking this PR except me being a little busy. I have some local improvements that I need to push to this PR before merging it but still hadn't got a chance to do so. Sorry about that.

@mikevanes
Copy link

mikevanes commented Sep 13, 2024

Any news on the progress on this PR? Would love to see it integrated so I can use Authentik.

@MohamedBassem
Copy link
Collaborator

@mikevanes I'll be merging it hopefully tomorrow. Again sorry about the delay.

@MohamedBassem
Copy link
Collaborator

@kamtschatka To keep this PR simple, I reverted the extension changes from this PR. You (or I can do it) send it in a separate PR after we land this one. I also did some minor changes to the decision or whether the user is an admin or not.
I'll test those changes now against my authentik setup, and if it works, I'll merge the PR.

@MohamedBassem
Copy link
Collaborator

Found a bug in the drizzle adapter definition that was preventing the correct propagation of the role from the profile to the database. Fixed in (80749d5). Testing one more time.

@MohamedBassem MohamedBassem merged commit b9724b7 into hoarder-app:main Sep 15, 2024
3 checks passed
@MohamedBassem
Copy link
Collaborator

Tested it and works flawlessly! Thanks a lot @kamtschatka (as usual) and I'm really really sorry for how long it took me to get to this PR. This is one of the most requested features :) It'll be available in the next release!

@mikevanes
Copy link

Thank you for the effort @MohamedBassem and @kamtschatka looking forward to the feature!

@kamtschatka kamtschatka deleted the oauth branch September 21, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants