-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for custom OIDC providers to set up authentication #92 #307
Conversation
Added support for custom OIDC providers to set up authentication
…der-app#92 Showing OAuth errors in the signin page
…der-app#92 Added the possibility to log in using an API key in case OAuth is used
…der-app#92 improved the code to also promote the first user to admin if OAuth is used
I want to manage my account in Hoarder through OIDC as well, and this PR looks good. Do we know what is blocking this PR? |
@winston0410 Nothing is blocking this PR except me being a little busy. I have some local improvements that I need to push to this PR before merging it but still hadn't got a chance to do so. Sorry about that. |
Any news on the progress on this PR? Would love to see it integrated so I can use Authentik. |
@mikevanes I'll be merging it hopefully tomorrow. Again sorry about the delay. |
@kamtschatka To keep this PR simple, I reverted the extension changes from this PR. You (or I can do it) send it in a separate PR after we land this one. I also did some minor changes to the decision or whether the user is an admin or not. |
Found a bug in the drizzle adapter definition that was preventing the correct propagation of the role from the profile to the database. Fixed in (80749d5). Testing one more time. |
Tested it and works flawlessly! Thanks a lot @kamtschatka (as usual) and I'm really really sorry for how long it took me to get to this PR. This is one of the most requested features :) It'll be available in the next release! |
Thank you for the effort @MohamedBassem and @kamtschatka looking forward to the feature! |
Added support for custom OIDC providers to set up authentication
I tried it with Google and Authentik and it worked great.
Only thing missing is showing the error message in "apps/web/components/signin/SignInForm.tsx", but I failed to do so, since it is a server side rendered component and I was not able to get the "error" parameter from the querystring and show it on screen.