Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): Add sans-serif fallback for Inter font in CJK character sets #272

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

kou029w
Copy link
Contributor

@kou029w kou029w commented Jul 4, 2024

Thank you for creating such awesome software.

This PR addresses the issue of Inter fonts not loading for CJK (Chinese, Japanese, and Korean) character sets, resulting in an inconsistent appearance. To improve consistency of appearance, a sans-serif fallback is specified. This ensures that if the Inter font fails to load, the generic sans-serif font will be used to maintain a consistent look across different character sets.

Original:
Screenshot 2024-07-04 at 11-08-18 Hoarder

This PR:
Screenshot 2024-07-04 at 11-08-44 Hoarder

Input text: "日本語表示確認用サンプル文"

@kou029w kou029w changed the title fix(web): Add sans-serif fallback for Inter font in CJK environments fix(web): Add sans-serif fallback for Inter font in CJK character sets Jul 4, 2024
@MohamedBassem MohamedBassem merged commit 72f03b2 into hoarder-app:main Jul 5, 2024
3 checks passed
@MohamedBassem
Copy link
Collaborator

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants