Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

long delay when selecting tags in UI #382

Closed
cirrusflyer opened this issue Sep 9, 2024 · 6 comments
Closed

long delay when selecting tags in UI #382

cirrusflyer opened this issue Sep 9, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@cirrusflyer
Copy link

I have nearly 4000 bookmarks, so a lot of tags. When I select the "Tags" on the left UI menu, it takes around 14 seconds to display the list. Hoarder is running on a server with a Celeron N5105, 16 GB RAM, and SSD storage.

@kamtschatka
Copy link
Contributor

This is most likely not related to the database query/your server, but rather on the UI showing all those tags.
How many tags do you have? Should you not have less tags than bookmarks, to keep everything grouped together?

@cirrusflyer
Copy link
Author

I have too many tags to count. Is there a way to get a count?

@cirrusflyer
Copy link
Author

Looks like over 6000 tags based on a copy and paste to another file and counting the rows.

kamtschatka added a commit to kamtschatka/hoarder-app that referenced this issue Sep 11, 2024
improved performance by not handling hover in css
also rendering the draggable div only if draggable mode is active
@kamtschatka
Copy link
Contributor

yeah, i was able to reproduce the issue, with 4000 tags that I added directly in the datbase and rendering took about 5 seconds for me.
I optimized the code and got it to below 2 seconds. Maybe someone else with more knowledge of React has better ideas, but at least it improved quite a bit already.

@cirrusflyer
Copy link
Author

That's a big improvement! Will that be pushed to Docker soon?

@kamtschatka
Copy link
Contributor

Depends on:

  • When it gets merged. I am a contributor, the maintainer needs to review and merge it
  • Which docker container you are using. If you are using stable, then it usually takes more than a month to release new versions, so you'll have to wait. If you are using the latest docker container, it would be made available pretty fast after the merge, but you'd be using a development version of hoarder, which potentially has more bugs.

@MohamedBassem MohamedBassem added the bug Something isn't working label Sep 15, 2024
kamtschatka added a commit to kamtschatka/hoarder-app that referenced this issue Oct 13, 2024
improved performance by not handling hover in css
also rendering the draggable div only if draggable mode is active
@github-project-automation github-project-automation bot moved this from In Progress to Done in Hoarder's Roadmap Oct 13, 2024
kamtschatka added a commit to kamtschatka/hoarder-app that referenced this issue Nov 2, 2024
 (hoarder-app#390)

* long delay when selecting tags in UI hoarder-app#382
improved performance by not handling hover in css
also rendering the draggable div only if draggable mode is active

* updated the code to reuse the DeleteTagConfirmationDialog to improve performance and fix the tag deletion

* some fixes

---------

Co-authored-by: MohamedBassem <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants