Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tagging behavior #368

Closed
kamtschatka opened this issue Sep 1, 2024 · 4 comments
Closed

Improve tagging behavior #368

kamtschatka opened this issue Sep 1, 2024 · 4 comments

Comments

@kamtschatka
Copy link
Contributor

kamtschatka commented Sep 1, 2024

I just added a bunch of links and moved them to a list. After that I noticed a few things:

  • Moving multiple bookmarks to a list is an absolute pain. We really should add that to the bulk edit mechanism
  • Editing tags has a few issues:
    • List of tags is not scrollable --> doesn't show all tags
    • Deleting all tags 1 by 1 is painful. In any other application if you press backspace, you can delete tags from the end of the tag list
    • I could have used a clear tags button, but that might have been too special to implement
    • What would also be nice would be to see all the tags assigned to the bookmarks in the current list, similar to what we have in the "tags" section(including merging). I would have been able to merge tags here as well (All bookmarks were of a similar topic, but i somehow ended up with 224 different tags for 14 different bookmarks)
@MohamedBassem
Copy link
Collaborator

Sent a quick commit to support adding to lists in bulk actions.

Regarding editing tags. Which list of tag are not scrollable? For me, both the one in Manage Lists and the one in Bookmark Preview are scrollable. As for the backspace, that makes sense and will probably remove the need for a "clear all tags".

@kamtschatka
Copy link
Contributor Author

if you press the "..." menu and then "Edit Tags". Turns out the list is actually scrollable, when it gets too long, but there is just no scroll bar, so it cuts off the top of the tags.

@MohamedBassem
Copy link
Collaborator

So how do you suggest we improve this scroll behavior?

@kamtschatka
Copy link
Contributor Author

I think we just have to make sure a scrollbar is shown, so it is obvious that it is a longer list.

kamtschatka added a commit to kamtschatka/hoarder-app that referenced this issue Sep 22, 2024
readded the scrollbar again, so it is obvious that the list is scrollable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants