Skip to content
This repository has been archived by the owner on Sep 20, 2021. It is now read-only.

Fix a null access with encryption+UDP #10

Merged
merged 1 commit into from
Sep 11, 2014

Conversation

Hywan
Copy link
Member

@Hywan Hywan commented Sep 10, 2014

Will fix #9.

@Hywan Hywan added the bug label Sep 10, 2014
@Hywan Hywan self-assigned this Sep 10, 2014
@Hywan
Copy link
Member Author

Hywan commented Sep 10, 2014

Asking the review of @Pierozi in particular.

@Pierozi
Copy link
Member

Pierozi commented Sep 10, 2014

How you used UDP with Encryption ?
On my MWE, your PR still pass my test in tcp mode.
but udp does not work, and has never work.

@Hywan
Copy link
Member Author

Hywan commented Sep 11, 2014

@Pierozi It does not work because we don't have nodes, since we use nodes with select + accept and we can't accept a UDP socket.

I propose to merge my PR: it removes a null access. Then, we open a new issue to support nodes (and therefore encryption) for UDP.

Thoughts?

@Pierozi
Copy link
Member

Pierozi commented Sep 11, 2014

👍 Yes, do it that.

@Bhoat Bhoat merged commit 5b391d5 into hoaproject:master Sep 11, 2014
@Hywan Hywan mentioned this pull request Sep 11, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

New encryption API causes a null access with UDP
3 participants