Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct to set cookie.httpOnly option to false #354

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

hannut91
Copy link
Contributor

@hannut91 hannut91 commented Nov 13, 2021

Even if the httpOnly option is set to false, it is set to true.
The logical OR (||) operator (logical disjunction) for a set of operands is true if and only if one or more of its operands is true.
So changed to use Nullish coalescing operator(??).

Issue: #353

See also

Even if the httpOnly option is set to false, it is set to true.
The logical OR (||) operator (logical disjunction) for a set of operands is true if and only if one or more of its operands is true.
So changed to use Nullish coalescing operator(??)

Issue: hoangvvo#353

See also
  - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Logical_OR
@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2021

⚠️ No Changeset found

Latest commit: 3e6bfb4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Nov 13, 2021

Codecov Report

Merging #354 (3e6bfb4) into master (a096734) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #354   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files           6        6           
  Lines         121      121           
  Branches       37       37           
=======================================
  Hits          120      120           
  Misses          1        1           
Impacted Files Coverage Δ
src/session.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a096734...3e6bfb4. Read the comment docs.

src/session.ts Show resolved Hide resolved
@hoangvvo
Copy link
Owner

I noticed that I have used it elsewhere anyway, so the previous comment is invalid!

@hoangvvo
Copy link
Owner

LGTM! Thanks!

@hoangvvo hoangvvo merged commit 17eec80 into hoangvvo:master Nov 17, 2021
@hoangvvo
Copy link
Owner

Published as v4.0.3. Thanks again for the PR and the very detailed description!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants