Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implement pipeline constructor from exec vector #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yurinnick
Copy link

No description provided.

@yurinnick yurinnick changed the title Implement pipeline constructor from exec vector [WIP] Implement pipeline constructor from exec vector Apr 8, 2020
@hniksic
Copy link
Owner

hniksic commented Apr 8, 2020

This looks very useful, thanks!

Could we change from_vec to from_iter and have it accept any type that implements IntoIterator<Item = Exec>? That way it would still accept a Vec<Exec>, but would also accept any other iterable that produces Execs.

@AlexanderThaller
Copy link
Contributor

Hello I would need this feature as well. Would it be ok if i make another pullrequest with the changes you recommended?

@hniksic
Copy link
Owner

hniksic commented Aug 27, 2021

@AlexanderThaller I have nothing against it, go ahead. The PR was marked WIP, so I didn't pay it full attention, but the change is quite straightforward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants