Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double slash in API path for networking #338

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

padm
Copy link
Contributor

@padm padm commented Aug 16, 2024

Currently with object NetworkingV1 extends APIGroupAPI("/apis/networking.k8s.io/v1/") we are getting API path with double slashes - "/apis/networking.k8s.io/v1//namespaces/default/ingresses".

Since others APIGroupAPI don't have ending slash, looks like it's not intended to have ending slash here.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution and welcome!
We are glad that you are here and we appreciate your contributions.

@hnaderi hnaderi merged commit 82bbeb6 into hnaderi:main Aug 16, 2024
12 of 14 checks passed
@hnaderi
Copy link
Owner

hnaderi commented Aug 16, 2024

@padm This is shipped with the new release which will be available after being published by the CI soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants