[ALS-5755] Switch time series processor to ISO timestamps #101
Conversation
Luke-Sikina
commented
Jan 23, 2024
Luke-Sikina
commented
- Make service that does this
- Isolate time series logic a bit more
- Tests
...va/edu/harvard/hms/dbmi/avillach/hpds/processing/timeseries/TimeSeriesConversionService.java
Outdated
Show resolved
Hide resolved
| @Service | ||
| public class TimeSeriesConversionService { | ||
|
|
||
| public String toISOString(Long unixTimeStamp, TimeZone timeZone) { |
There was a problem hiding this comment.
I don't love the idea of converting these to UTC, or them being time-zoned at all, but that's probably out of the scope of this ticket. It is something to think about for the future, what do these timestamps represent exactly?
There was a problem hiding this comment.
It's a Unix timestamp; they're UTC or we're not following the standard correctly.
There was a problem hiding this comment.
I added the timezone to be explicit about the output
There was a problem hiding this comment.
I was kind of asking rhetorically, sometimes these are when the data was processed, sometimes they are when a medication was given or a test result. Which loses meaning if you don't know the local time. I'm guessing 99% of our data is in 4 time zones so currently it's not much of an issue
Luke-Sikina
force-pushed
the
iso-timeseries
branch
from
cb53e96 to
dc03f3e
Compare
| @Service | ||
| public class TimeSeriesConversionService { | ||
|
|
||
| public String toISOString(Long unixTimeStamp) { |
There was a problem hiding this comment.
Do we actually want to do this -- we are losing information, the person requesting the data may be better off just getting the unix time stamp, no?
Luke-Sikina
force-pushed
the
iso-timeseries
branch
from
dc03f3e to
1919f66
Compare
- Make service that does this - Isolate time series logic a bit more - Tests
Luke-Sikina
force-pushed
the
iso-timeseries
branch
from
1919f66 to
35797d0
Compare
Luke-Sikina
force-pushed
the
iso-timeseries
branch
3 times, most recently
from
673e15f to
35797d0
Compare
