V0.43.0 hmhco #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etotten
reviewed
Jan 27, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per BEDROCK-6218
See:
https://discuss.hashicorp.com/t/delay-sigterm-of-envoy-sidecar-proxy/22036/3
hashicorp#536
for more detailed explanation of the issue
upgrades to consul k8s will break gracefulness of ingress, this PR adds a default delay of 3 seconds for the envoy sidecar. This allows enough time for consul service to be deregistered before envoy gets a SIGTERM
i have opened a ticket with hashicorp and linked this code along with details why.
They confirmed this solution is feasible approach atm.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: