VIH-10352 Add users to AAD groups before sending notifications #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-scott
commented
Dec 6, 2023
oliver-scott
changed the title
oliver-scott
force-pushed
the
bug/VIH-10352-create-users
branch
from
ac2d390 to
6407137
Compare
oliver-scott
changed the title
komaldabhi1509
previously approved these changes
Dec 7, 2023
oliver-scott
dismissed stale reviews from komaldabhi1509 and marcogagliardi
via
fe37173
komaldabhi1509
approved these changes
Dec 7, 2023
|
Kudos, SonarCloud Quality Gate passed! |
oliver-scott
added a commit
that referenced
this pull request
Dec 7, 2023
* Assign users to groups after sending notifications * Update test config * Update test config * Revert test config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link (if applicable)
https://tools.hmcts.net/jira/browse/VIH-10352
Change description
Add users to groups before sending the notifications, to ensure that users are still added to the AAD groups in the event of a notification failure.
Not required to fix the original issue, but makes the handling more robust.