Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIH-10175 Refactor health check to improve startup and liveness #213

Closed
wants to merge 8 commits into from

Conversation

shaed-parkar
Copy link
Contributor

JIRA link (if applicable)

VIH-10175

Change description

Refactor health check

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

@shaed-parkar shaed-parkar requested review from a team as code owners September 15, 2023 08:53
renovate bot and others added 6 commits September 15, 2023 11:20
* VIH-0000 - Renovate - Update Helm release java to v4.2.0

* Bumping chart version

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: hmcts-ado-cnp <174565+hmcts-ado-cnp[bot]@users.noreply.github.com>
… an ejud username (for applicable roles only) (#214)

This applies to Judge and Judicial Office Holders only
@shaed-parkar
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

82.6% 82.6% Coverage
0.0% 0.0% Duplication

oliver-scott
oliver-scott previously approved these changes Sep 21, 2023
Copy link
Contributor

@oliver-scott oliver-scott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

health checks seem good. It looks like this PR also fixes an issue with notifications? Might be worth adding the ticket number to the PR description, just for reference

@shaed-parkar shaed-parkar dismissed oliver-scott’s stale review September 21, 2023 15:05

The merge-base changed after approval.

@shaed-parkar
Copy link
Contributor Author

health checks seem good. It looks like this PR also fixes an issue with notifications? Might be worth adding the ticket number to the PR description, just for reference

The bug fix was merged in PR #214 . I just took a branch off that for this branch

oliver-scott
oliver-scott previously approved these changes Sep 21, 2023
@shaed-parkar shaed-parkar dismissed oliver-scott’s stale review September 21, 2023 16:31

The merge-base changed after approval.

@shaed-parkar
Copy link
Contributor Author

replaced with #215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants